CASSANDRA-21236: Don’t leave autocompaction disabled during bootstrap and replace#4682
Open
krummas wants to merge 2 commits intoapache:trunkfrom
Open
CASSANDRA-21236: Don’t leave autocompaction disabled during bootstrap and replace#4682krummas wants to merge 2 commits intoapache:trunkfrom
krummas wants to merge 2 commits intoapache:trunkfrom
Conversation
We have always disabled autocompaction for all known tables during startup, to allow commitlog replay to flush without triggering compactions. Problem is that now with CEP-21/TCM we know all tables before disabling. Fix is simple, just re-enable autocompaction earlier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have always disabled autocompaction for all known tables during startup, to allow commitlog replay to flush without triggering compactions. Problem is that now with CEP-21/TCM we know all tables before disabling. Fix is simple, just re-enable autocompaction earlier
Thanks for sending a pull request! Here are some tips if you're new here:
Commit messages should follow the following format:
The Cassandra Jira