[AURON #2001] Upgrade Rust nightly toolchain to 2025-12-15.#2002
[AURON #2001] Upgrade Rust nightly toolchain to 2025-12-15.#2002slfan1989 wants to merge 2 commits intoapache:masterfrom
Conversation
|
I remember that using |
@cxzl25 Thank you so much for the reply! I tried searching for it, but couldn’t find any information about a JVM crash caused on 2025-06-20. However, Iceberg-Rust is already using 2025-06-23. Should we give it a try? https://github.com/apache/iceberg-rust/blob/main/rust-toolchain.toml |
|
i suggest to use a more recent nightly version (if it works) |
Thanks for the suggestion! I’ll try a more recent nightly version. |
ea9b0b5 to
d476b9f
Compare
Signed-off-by: slfan1989 <slfan1989@apache.org>
91aa9ac to
3aa85c4
Compare
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Rust nightly toolchain from nightly-2025-05-09 to nightly-2025-12-15 and applies automatic code refactorings enabled by newer Rust compiler features. The upgrade incorporates compiler improvements, bug fixes, and new language features including let-chains and improved standard library APIs.
Changes:
- Updated Rust nightly toolchain version in
rust-toolchain.toml - Refactored nested if-let statements to use let-chain syntax for improved readability
- Replaced manual clone operations with
std::slice::from_reffor better performance - Updated compiler intrinsics to use new const generic syntax for
prefetch_read_dataandprefetch_write_data - Replaced manual bit rotation with
rotate_leftmethod - Removed unused
vec_into_raw_partsfeature flag - Applied clippy suggestions for removing unnecessary parentheses
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| rust-toolchain.toml | Updated toolchain version from nightly-2025-05-09 to nightly-2025-12-15 |
| parquet_sink_exec.rs | Removed unnecessary parentheses in send call |
| orc_exec.rs | Refactored nested if-let statements to use let-chain syntax |
| generate_exec.rs | Replaced clone with std::slice::from_ref |
| debug_exec.rs | Replaced clone with std::slice::from_ref |
| execution_context.rs | Refactored nested if-let statements to use let-chain syntax |
| cached_exprs_evaluator.rs | Refactored nested if-let statements to use let-chain syntax |
| agg_exec.rs | Removed unnecessary parentheses and replaced modulo check with is_multiple_of |
| agg_table.rs | Refactored nested if-let statements to use let-chain syntax |
| acc.rs | Refactored nested if-let statements to use let-chain syntax |
| spark_strings.rs | Refactored nested if-let statements to use let-chain syntax |
| spark_get_json_object.rs | Refactored nested if-let statements to use let-chain syntax |
| spark_dates.rs | Improved formatting of multi-line expression |
| spark_hash.rs | Replaced clone with std::slice::from_ref in tests |
| lib.rs | Removed vec_into_raw_parts feature and updated prefetch intrinsics to use const generic syntax |
| ipc_compression.rs | Replaced clone with std::slice::from_ref in tests |
| batch_serde.rs | Replaced clone with std::slice::from_ref in tests |
| xxhash.rs | Replaced manual bit rotation with rotate_left method |
| spill.rs | Refactored nested if-let statements to use let-chain syntax |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| [toolchain] | ||
| channel = "nightly-2025-05-09" | ||
| channel = "nightly-2025-12-15" |
There was a problem hiding this comment.
The PR description states the upgrade is for "the past 45 days (2025-05-09 to 2025-12-15)", but the time span from May 9 to December 15, 2025 is approximately 220 days (about 7 months), not 45 days. Additionally, the linked issue #2001 mentions upgrading to "nightly-2025-06-23" (which would indeed be about 45 days from May 9), but the actual version being used here is "nightly-2025-12-15". Please verify which version is intended and correct the PR description accordingly.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
native-engine/datafusion-ext-functions/src/spark_get_json_object.rs
Outdated
Show resolved
Hide resolved
…ct.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Which issue does this PR close?
Closes #2001
Rationale for this change
Upgrade the Rust nightly toolchain to incorporate compiler improvements, bug fixes, and optimizations from the past 45 days (2025-05-09 to 2025-12-15).
What changes are included in this PR?
rust-toolchain.toml:nightly-2025-05-09→nightly-2025-12-15Are there any user-facing changes?
No.
How was this patch tested?
CI pipeline verification