[AMORO-4099] Add table-summary metric collection option for non-optimizing tables#4101
Draft
j1wonpark wants to merge 1 commit intoapache:masterfrom
Draft
[AMORO-4099] Add table-summary metric collection option for non-optimizing tables#4101j1wonpark wants to merge 1 commit intoapache:masterfrom
j1wonpark wants to merge 1 commit intoapache:masterfrom
Conversation
…izing tables Signed-off-by: Jiwon Park <jpark92@outlook.kr>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4101 +/- ##
============================================
+ Coverage 22.39% 28.86% +6.46%
- Complexity 2552 3951 +1399
============================================
Files 458 654 +196
Lines 42116 52175 +10059
Branches 5917 6637 +720
============================================
+ Hits 9433 15061 +5628
- Misses 31871 36013 +4142
- Partials 812 1101 +289
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Currently,
table_summarymetrics (total files, file sizes, health score, etc.) are only collected whenself-optimizing.enabled=true. The metric update path (setTableSummary()) is gated behind theoptimizingConfig.isEnabled()check inTableRuntimeRefreshExecutor.tryEvaluatingPendingInput(), so tables with self-optimizing disabled always show 0 or N/A in Grafana dashboards.This PR decouples metric collection from self-optimizing execution by introducing a new table property.
Close #4099.
Brief change log
self-optimizing.table-summary.enabledtable property constant inTablePropertiestableSummaryEnabledfield toOptimizingConfigwith getter/setterTableConfigurations.parseOptimizingConfig()else ifbranch inTableRuntimeRefreshExecutor.tryEvaluatingPendingInput()to collect summary metrics when optimizing is disabled but table-summary is enabledTestTableSummaryWithoutOptimizingtest class with 2 test casesHow was this patch tested?
testSummaryCollectedWhenOptimizingDisabledAndSummaryEnabled: verifies metrics are updated when optimizing is off but summary is enabledtestSummaryNotCollectedWhenBothDisabled: verifies metrics remain at initial values when both are disabledDocumentation