Merged
Conversation
MykolaSuperman
force-pushed
the
checksum_imagemanager
branch
from
d687a17 to
e808895
Compare
mlohvynenko
reviewed
Mar 23, 2026
src/core/common/tools/fs.hpp
Outdated
| @@ -260,6 +260,7 @@ struct FileInfo { | |||
| FileInfo() = default; | |||
|
|
|||
| StaticArray<uint8_t, crypto::cSHA256Size> mSHA256; | |||
Member
There was a problem hiding this comment.
Probably we should store AlgEnum value and a static array with the ectual hash (using Max(crypto::cSHA256Size, ....) as size if needed) >
mlohvynenko
approved these changes
Mar 23, 2026
Member
mlohvynenko
left a comment
mlohvynenko
left a comment
There was a problem hiding this comment.
Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>
al1img
reviewed
Mar 23, 2026
src/core/common/tools/fs.cpp
Outdated
| info.mSize = size; | ||
|
|
||
| return crypto::CalculateFileHash(path, crypto::HashEnum::eSHA256, *mHashProvider, info.mSHA256); | ||
| if (auto hashErr = crypto::CalculateFileHash(path, crypto::HashEnum::eSHA256, *mHashProvider, info.mSHA256); |
Collaborator
There was a problem hiding this comment.
It is not efficient to calculate checksum twice. Add bool parameter sha3 with default set to false.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #534 +/- ##
===========================================
- Coverage 85.28% 85.27% -0.01%
===========================================
Files 311 311
Lines 27932 27955 +23
Branches 3769 3772 +3
===========================================
+ Hits 23821 23839 +18
- Misses 4111 4116 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mykola-kobets-epam
approved these changes
Mar 23, 2026
Contributor
mykola-kobets-epam
left a comment
mykola-kobets-epam
left a comment
There was a problem hiding this comment.
Reviewed-by: Mykola Kobets <mykola_kobets@epam.com>
MykolaSuperman
force-pushed
the
checksum_imagemanager
branch
4 times, most recently
from
2fd725e to
d62e39c
Compare
al1img
approved these changes
Mar 23, 2026
Collaborator
al1img
left a comment
al1img
left a comment
There was a problem hiding this comment.
Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
added 3 commits
March 23, 2026 15:41
Replace mSHA256 with generic mCheckSum array and hashAlg parameter in GetFileInfo to support multiple hash algorithms. Add cSHA512Size constant. Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>
Add pre-decrypt checksum verification using SHA3-256 against blobInfo.mSHA256 in EnsureBlob with retry loop on mismatch. Change post-decrypt verification in DecryptAndValidateBlob to use VerifyBlobChecksum with blobInfo.mDigest instead of blobInfo.mSHA256. Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>
Update GetBlobsInfos mocks to use proper 64-char hex digest matching the test SHA256 pattern. Add mSHA3_256 population to GetFileInfo mocks for pre-decrypt checksum verification. Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>
MykolaSuperman
force-pushed
the
checksum_imagemanager
branch
from
d62e39c to
284fcd8
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.