Conversation
mlohvynenko
left a comment
mlohvynenko
left a comment
There was a problem hiding this comment.
Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>
| return; | ||
| } | ||
|
|
||
| mMessageLogFile << direction << ": " << message << "\n"; |
There was a problem hiding this comment.
std::endl can be used:
It adds eol and flushes buffer
| return {{}, Error(ErrorEnum::eInvalidArgument, "invalid duration string")}; | ||
| } | ||
|
|
||
| RetWithError<Time> FromUTCString(const std::string& utcTimeStr) |
There was a problem hiding this comment.
Public header still declares FromUTCString/ToUTCString, but implementations were removed
time.hpp (line 38), time.hpp (line 46), time.cpp (line 176)
src/common/utils/time.cpp no longer defines FromUTCString / ToUTCString, but src/common/utils/time.hpp still declares them. Internal tree compiles because call sites were migrated, but external consumers including this header can still compile and then fail at link time with undefined symbols.
Either keep compatibility wrappers or remove declarations (and handle API change explicitly).
mykola-kobets-epam
left a comment
mykola-kobets-epam
left a comment
There was a problem hiding this comment.
Reviewed-by: Mykola Kobets <mykola_kobets@epam.com>
Log all messages received and sent to/from cloud to dedicated file specified by "cloudMessageLog" in config. Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com>
Same conversion functions are available in core lib time module. Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com>
Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #186 +/- ##
==========================================
Coverage ? 82.52%
==========================================
Files ? 325
Lines ? 31034
Branches ? 3221
==========================================
Hits ? 25611
Misses ? 5423
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
4 participants
No description provided.