cm: fix application crash on cert handler CreateKey call#184
Merged
al1img merged 1 commit intoaosedge:developfrom Mar 20, 2026
Merged
cm: fix application crash on cert handler CreateKey call#184al1img merged 1 commit intoaosedge:developfrom
al1img merged 1 commit intoaosedge:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #184 +/- ##
==========================================
Coverage ? 82.54%
==========================================
Files ? 325
Lines ? 31083
Branches ? 3220
==========================================
Hits ? 25657
Misses ? 5426
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
al1img
approved these changes
Mar 20, 2026
Collaborator
al1img
left a comment
al1img
left a comment
There was a problem hiding this comment.
Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
MykolaSuperman
approved these changes
Mar 20, 2026
MykolaSuperman
left a comment
MykolaSuperman
left a comment
There was a problem hiding this comment.
Reviewed-by: Mykola Solianko <mykola_solianko@epam.com>
mlohvynenko
force-pushed
the
bugfix_cm_create_key_call
branch
from
1bcbb86 to
d55498b
Compare
Collaborator
mykola-kobets-epam
left a comment
mykola-kobets-epam
left a comment
There was a problem hiding this comment.
probably better add default constructor to String, because it uses Array's constructir
mykola-kobets-epam
approved these changes
Mar 20, 2026
Collaborator
mykola-kobets-epam
left a comment
mykola-kobets-epam
left a comment
There was a problem hiding this comment.
Reviewed-by: Mykola Kobets <mykola_kobets@epam.com>
String default constructor initializes internal buffer with nullptr, causing a crash in CreateKey when the param is converted to std::string via CStr call. Initialize with an empty string literal instead to ensure the internal buffer points to valid memory. Signed-off-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
mlohvynenko
force-pushed
the
bugfix_cm_create_key_call
branch
from
d55498b to
b075a87
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String default constructor initializes internal buffer with nullptr, causing a crash in CreateKey when the param is converted to std::string via CStr call.
Initialize with an empty string literal instead to ensure the internal buffer points to valid memory.