Image manager by al1img · Pull Request #120 · aosedge/aos_core_cpp

al1img · 2025-12-22T18:38:14Z

No description provided.

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

Signed-off-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com>

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

This patch adds handling of CPU information parameters in the node configuration. Also it fixes the config module unit tests compilation. Signed-off-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

Signed-off-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com>

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

Signed-off-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>

Service discovery config URL is needed to populate the request path only, while the actual connection should be made to the hostname specified in the certificate. Signed-off-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

This patch removes call to uname system function to populate OS information. All the required information is now taken from the configuration. Signed-off-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>

Signed-off-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>

Fix useStlAlgorithm issue. Signed-off-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>

- add state & isUnitSubject to launcher_instances - remove cached from launcher_instances - remove OnEnvVarsStatusesReceived from InstanceStatusReceiverStub Signed-off-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>

Copilot

Pull request overview

This PR introduces a new image manager component for handling OCI (Open Container Initiative) image layers within the SM (Service Manager) module. The implementation provides functionality for unpacking layer archives, calculating directory digests, and determining unpacked layer sizes.

Key Changes:

Added ImageHandler class with methods for layer unpacking, size calculation, and digest computation
Refactored common utilities: renamed HashDir to CalculateDirDigest for better clarity and extracted ChangeOwner into a reusable utility function
Extended OCI spec support to handle rootfs configuration in image configs

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
src/sm/imagemanager/imagehandler.hpp	Defines ImageHandler interface with Init, UnpackLayer, GetUnpackedLayerSize, and GetUnpackedLayerDigest methods
src/sm/imagemanager/imagehandler.cpp	Implements image layer handling including OCI whiteout conversion to overlayfs format
src/sm/imagemanager/tests/imagemanager.cpp	Adds test for layer unpacking, size calculation, and digest verification
src/sm/imagemanager/tests/CMakeLists.txt	Build configuration for image manager tests
src/sm/imagemanager/CMakeLists.txt	Build configuration for image manager module
src/sm/app/CMakeLists.txt	Integrates image manager library into SM application
src/sm/CMakeLists.txt	Adds image manager subdirectory to SM build
src/common/utils/image.hpp	Renames HashDir to CalculateDirDigest and updates ParseDigest signature
src/common/utils/image.cpp	Updates digest calculation to include relative file paths and standardizes error message casing
src/common/utils/filesystem.hpp	Adds ChangeOwner utility function declaration
src/common/utils/filesystem.cpp	Implements ChangeOwner to recursively change file/directory ownership
src/common/utils/fsplatform.cpp	Refactors ChangeOwner to use new filesystem utility function
src/common/utils/tests/image.cpp	Updates test name from HashDirTest to CalculateDirDigest
src/common/ocispec/imageconfig.cpp	Adds rootfs parsing and serialization support for OCI image configs
src/common/ocispec/tests/ocispec.cpp	Adds rootfs test data to image config test fixture

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/common/utils/filesystem.cpp

src/sm/imagemanager/imagehandler.cpp

src/sm/imagemanager/imagehandler.hpp

src/common/utils/filesystem.hpp

src/sm/imagemanager/imagehandler.cpp

src/sm/imagemanager/tests/imagemanager.cpp

src/sm/imagemanager/imagehandler.cpp

src/common/ocispec/imageconfig.cpp

src/common/utils/filesystem.cpp

Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>

Move ChangeOwner to filesystem in order to use it without FS platform instance. Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>

Rename HashDir to CalculateDirDigest and uses Digest type name. Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/common/utils/filesystem.hpp

src/sm/imagemanager/tests/imagemanager.cpp

codecov · 2025-12-23T11:02:26Z

Codecov Report

❌ Patch coverage is 83.76623% with 25 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feature_unification@2fa25b0). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
src/sm/imagemanager/imagehandler.cpp	65.38%	18 Missing ⚠️
src/sm/imagemanager/tests/imagemanager.cpp	93.22%	4 Missing ⚠️
src/common/utils/image.cpp	50.00%	3 Missing ⚠️

Additional details and impacted files

@@                  Coverage Diff                   @@
##             feature_unification     #120   +/-   ##
======================================================
  Coverage                       ?   82.20%           
======================================================
  Files                          ?      266           
  Lines                          ?    25209           
  Branches                       ?     2620           
======================================================
  Hits                           ?    20724           
  Misses                         ?     4485           
  Partials                       ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Implement image handler interface for SM image manger. Most parts are taken from previous image module. Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>

sonarqubecloud · 2025-12-23T13:10:36Z

Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

Mykola Solianko and others added 30 commits December 12, 2025 13:39

sm: tests: add UT

7a8c3b5

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

sm: smclient: update deps

47cab2e

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

sm: cmake: make smclient build

9e5a694

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

fixup! sm: tests: add UT

5b55c76

cm: add database module

aae7c6c

Signed-off-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com>

cm: database: add InstanceIdent::mType to database

936a8fb

Signed-off-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com>

pbconvert: add convert for sm message

fab995d

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

sm: smclient: add handlers for incomig msg

f33dd90

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

sm: smclient: update UT

a32fbce

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

cm: database: implement imagemanager storage

9cc8146

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

iam: config: handle node info cpu parameters

553dcae

This patch adds handling of CPU information parameters in the node configuration. Also it fixes the config module unit tests compilation. Signed-off-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

iam: currentnode: use config provided cpu name, arch and variant

591c9dd

Signed-off-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

cm: unitconfig: add UnitConfig JSON provider

4c58522

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

cm: unitconfig: add UT

8745347

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

cm: cmake: enable unitconfig

847db51

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

cm: cmake: add required Poco modules to find_package

b1e739d

Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com>

cm: communication: add setting item type for UpdateItemInfo

672024b

Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com>

sm: image: remove imagehandler

99da793

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

sm: launcher: remove launcher

3cd65de

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

sm: runner: remove runner

728d822

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

sm: config: remove unused component configurations

829c47a

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

sm: database: remove unused storage interfaces

2c52891

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

sm: alerts: extract interfaces to separate files

fc3f8fb

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

sm: logprovider: use core logging types

9d628f4

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

sm: monitoring: fix iamclient namespace

56cde77

Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

mlohvynenko and others added 14 commits December 19, 2025 17:55

cm: config: parse fileserver URL

c9252a4

Signed-off-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>

cm: app: initialize and start fileserver

a0c607c

Signed-off-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>

sm: smclient: wait for node instances status in UT

39e1acb

Signed-off-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>

cm: app: initialize monitoring with cloud connection

6fd826b

Signed-off-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>

cm: app: initialize alerts with cloud connection

b611f2b

Signed-off-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>

sm: monitoring: set partition name

6f4c013

Signed-off-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>

sm: alerts: fix aler module and start it in sm app

30b1115

Signed-off-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>

sm: alers: fix static analysis issue

9535762

Fix useStlAlgorithm issue. Signed-off-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>

Copilot AI review requested due to automatic review settings December 22, 2025 18:38

Copilot started reviewing on behalf of al1img December 22, 2025 18:38 View session

Copilot AI reviewed Dec 22, 2025

View reviewed changes

common: ocispec: add parsing rootfs node in image config

6dd7677

Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>

al1img force-pushed the image_manager branch from 5c95de7 to 8db8493 Compare December 23, 2025 10:36

al1img added 2 commits December 23, 2025 12:40

common: utils: move ChangeOwner implementation to filesystem

8584f49

Move ChangeOwner to filesystem in order to use it without FS platform instance. Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>

common: utils: refactor image utils

2f85fca

Rename HashDir to CalculateDirDigest and uses Digest type name. Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>

al1img force-pushed the image_manager branch from 8db8493 to 83e8c13 Compare December 23, 2025 10:40

al1img requested a review from Copilot December 23, 2025 10:41

Copilot started reviewing on behalf of al1img December 23, 2025 10:42 View session

Copilot AI reviewed Dec 23, 2025

View reviewed changes

src/common/utils/filesystem.hpp Show resolved Hide resolved

src/sm/imagemanager/tests/imagemanager.cpp Show resolved Hide resolved

src/sm/imagemanager/tests/imagemanager.cpp Show resolved Hide resolved

sm: imagemanager: implement image handler

e2f36a6

Implement image handler interface for SM image manger. Most parts are taken from previous image module. Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>

al1img force-pushed the image_manager branch from 83e8c13 to e2f36a6 Compare December 23, 2025 12:41

mlohvynenko force-pushed the feature_unification branch from db9f798 to f79cf08 Compare February 27, 2026 13:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Image manager#120

Image manager#120
al1img wants to merge 77 commits intoaosedge:feature_unificationfrom
al1img:image_manager

al1img commented Dec 22, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Dec 23, 2025 •

edited

Loading

Uh oh!

sonarqubecloud bot commented Dec 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Conversation

al1img commented Dec 22, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sonarqubecloud bot commented Dec 23, 2025

Quality Gate failed

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

codecov bot commented Dec 23, 2025 •

edited

Loading