This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(CONTRIBUTING): add warning about forced push#13747
Closed
dmitriz wants to merge 1 commit intoangular:masterfrom
dmitriz:patch-3
Closed
docs(CONTRIBUTING): add warning about forced push#13747dmitriz wants to merge 1 commit intoangular:masterfrom dmitriz:patch-3
dmitriz wants to merge 1 commit intoangular:masterfrom
dmitriz:patch-3
Conversation
Contributor
|
Instead, I think we need to change the wording to be... |
Contributor
Author
|
So no warning? What if a maintainer will ask to force push forgetting the consequences? With an old PR especially this may lead to loss of people's work. |
Member
|
Without squashing, there shouldn't be any loss, right ? |
Contributor
Author
|
Squashing is part of And things other than squashing might also affect it. |
Contributor
|
OK, so you can add the warning as a line after what I wrote :-) |
Add warning about the possible consequences of a forced push docs(CONTRIBUTING): add warning about forced push
Contributor
|
Thanks for the changes - they are nearly right. I will fix up and merge. |
petebacondarwin
pushed a commit
that referenced
this pull request
Jan 12, 2016
Add warning about the possible consequences of a forced push Closes #13747
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add warning about the possible consequences of a forced push
docs(CONTRIBUTING): add warning about forced push
Replacing #13719