Open
Conversation
Wiebke
reviewed
Apr 7, 2026
Contributor
Wiebke
left a comment
Wiebke
left a comment
There was a problem hiding this comment.
I’m a bit unclear on the intended environment management here, this looks like a mix of pyproject.toml and pixi. Is the idea to keep installation without pixi possible for package use, docker builds etc?
CI/CD failing looks like related to pip install ".[dev,testing]" no longer existing, that will need to be updated to make use of pixi.
Rename looks consistent overall, but I spotted 1–2 places where als_tiled is still lingering.
| @@ -0,0 +1,34 @@ | |||
|
|
|||
| [workspace] | |||
| name = "als_tiled" | |||
Contributor
There was a problem hiding this comment.
Suggested change
| name = "als_tiled" | |
| name = "splash_tiled" |
| Docker images are automatically published to: | ||
| ``` | ||
| ghcr.io/als-lbl/als_tiled | ||
| ghcr.io/als-lbl/splash_tiled |
Contributor
There was a problem hiding this comment.
The rename is good, but we might want to correct the link.
Suggested change
| ghcr.io/als-lbl/splash_tiled | |
| ghcr.io/als-computing/splash_tiled |
| ```bash | ||
| pixi run lint # Run all linters | ||
| pixi run format # Format code with black and isort | ||
| pixi run typecheck # Run mypy type checks |
Contributor
There was a problem hiding this comment.
typecheck is not currently listed under the pixi tasks.
| cd splash_tiled | ||
|
|
||
| # Install in development mode | ||
| pip install -e .[dev] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
als_tiledtosplash_tiled