Skip to content

fix operator queue and redis #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dylanmcreynolds merged 2 commits into from
Apr 2, 2026
Merged

fix operator queue and redis #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f65d038
fix operator queue and redis
dylanmcreynolds Apr 1, 2026
ab499dd
undo redis change
dylanmcreynolds Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pixi.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions src/arroyopy/operator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ def add_publisher(self, publisher: Publisher) -> None:
def remove_publisher(self, publisher: Publisher) -> None:
self.publishers.remove(publisher)

async def notify(self, message: Message) -> None:
await self.listener_queue.put(message)

async def publish(self, message: Message) -> None:
for publisher in self.publishers:
await publisher.publish(message)
Expand Down
7 changes: 7 additions & 0 deletions src/arroyopy/redis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,13 @@ async def stop(self):
await self.redis_client.aclose()


def redis_listener_factory(
redis_uri: str, redis_channel_name: str, operator: Operator = None
) -> RedisListener:
redis_client = Redis(redis_uri)
return RedisListener(redis_client, redis_channel_name)
Comment on lines +51 to +55
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redis_listener_factory accepts an operator parameter but never uses it, and it returns a RedisListener that (per current implementation) has no operator set, so the produced listener cannot function. Either remove the unused parameter or pass it through and ensure the listener is fully initialized (consistent with how listeners are instantiated elsewhere).

Copilot uses AI. Check for mistakes.


class RedisPublisher(Publisher):
def __init__(self, redis_client: Redis, redis_channel_name: str):
self.redis_client: Redis = redis_client
Expand Down
Loading