fix: remove dead code in recommendations.py and replace print with logging in quiz_views.py

[YiranHu361]

Summary

• web/recommendations.py: Removed duplicate return similar_courses[:limit] on line 85 of get_similar_courses() — this was unreachable dead code from a copy-paste error.
• web/quiz_views.py: Replaced bare print(e) with logger.exception("Error adding question to quiz") in the add_question view, consistent with the ongoing effort to replace print statements with proper logging (see Replace print statements with proper logging in peer_challenge_views.py #1021, Replace print statements with logger.error in middleware.py #1033, REFACTOR: Replace prints with proper logging #1036). Added import logging and logger = logging.getLogger(__name__).

Test plan

• Verified both files pass Python syntax validation
• Confirmed no existing tests break (no dedicated tests exist for these modules)
• Manual test: create a quiz and add a question to verify the logging change doesn't affect behavior

🤖 Generated with Claude Code

This PR removes dead code and improves error logging across two files:

web/quiz_views.py:

• Added structured logging support by importing the logging module and creating a module-level logger
• Replaced a print(e) statement in the add_question POST error handler (line 188) with logger.exception("Error adding question to quiz") to provide better error tracking and stack trace capture instead of simple console printing
• This aligns the logging approach with previous PRs and improves debugging capabilities

web/recommendations.py:

• Removed a duplicate, unreachable return similar_courses[:limit] statement at the end of the get_similar_courses() function that resulted from copy-paste code
• This eliminates dead code without affecting function behavior

Impact: No functional changes to user experience. The logging improvement provides better application observability when errors occur during quiz question additions. Both files pass syntax validation with no breaking changes to existing tests.

[github-actions]

👀 Peer Review Required

Hi @YiranHu361! This pull request does not yet have a peer review.

Before this PR can be merged, please request a review from one of your peers:

• Go to the PR page and click "Reviewers" on the right sidebar.
• Select a team member or contributor to review your changes.
• Once they approve, this reminder will be automatically removed.

Thank you for contributing! 🎉

[coderabbitai]

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)

Validation error: Unrecognized key(s) in object: 'tools'

⚙️ Configuration instructions

• Please see the configuration documentation for more information.
• You can also validate your configuration using the online YAML validator.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

This PR introduces logging infrastructure to exception handling in the quiz views module and removes unreachable duplicate code in the recommendations module. Two files are improved through these targeted fixes.

Changes

Cohort / File(s)	Summary
Logging Infrastructure web/quiz_views.py	Added Python logging module import and module-level logger initialization. Replaced print(e) with logger.exception() in the add_question POST error handler to properly capture exception stack traces.
Code Cleanup web/recommendations.py	Removed unreachable duplicate return similar_courses[:limit] statement at the end of the get_similar_courses function, eliminating dead code.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

• duplicate return at the end of get_similar_courses (recommendations.py) #830: The removal of the duplicate unreachable return statement in web/recommendations.py directly addresses this issue's objective.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes both main changes: removing dead code in recommendations.py and replacing print with logging in quiz_views.py.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@web/quiz_views.py`:
- Around line 187-190: The except block currently binds an unused variable
(`except Exception as e:`) even though logger.exception() uses the exception
context; change the handler to `except Exception:` in the same block where
logger.exception("Error adding question to quiz") and the subsequent re-raise
occur (look for the except around logger.exception in quiz_views.py) to remove
the unused `e` and avoid linter warning F841.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: alphaonelabs/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 25df9e8c-e14b-4e90-9a43-04bc61c9fa16

📥 Commits

Reviewing files that changed from the base of the PR and between c94caf8 and 278cfde.

📒 Files selected for processing (2)

• web/quiz_views.py
• web/recommendations.py

💤 Files with no reviewable changes (1)

• web/recommendations.py

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

Good switch to structured logging! Minor cleanup: remove unused variable e.

The change from print(e) to logger.exception() is excellent—logger.exception() automatically captures the full traceback from the current exception context, so there's no need to reference e at all.

Since e is now unused, consider simplifying to except Exception: to avoid potential linter warnings (flake8 F841).

🧹 Suggested cleanup

-            except Exception as e:
+            except Exception:
                 logger.exception("Error adding question to quiz")
                 # Re-raise the exception
                 raise

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	except Exception as e:
	print(e)
	logger.exception("Error adding question to quiz")
	# Re-raise the exception
	raise
	except Exception:
	logger.exception("Error adding question to quiz")
	# Re-raise the exception
	raise

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@web/quiz_views.py` around lines 187 - 190, The except block currently binds
an unused variable (`except Exception as e:`) even though logger.exception()
uses the exception context; change the handler to `except Exception:` in the
same block where logger.exception("Error adding question to quiz") and the
subsequent re-raise occur (look for the except around logger.exception in
quiz_views.py) to remove the unused `e` and avoid linter warning F841.