Removing cd to undefined BUILD_DIR. Each component has its own cd so this line is not necessary.#250
Removing cd to undefined BUILD_DIR. Each component has its own cd so this line is not necessary.#250marcodamico wants to merge 1 commit intoaliyun:masterfrom
cd to undefined BUILD_DIR. Each component has its own cd so this line is not necessary.#250Conversation
…this line looks not necessary.
|
|
There was a problem hiding this comment.
Pull request overview
This PR updates the astra-sim-alibabacloud component build wrapper to avoid changing directories into an undefined ${BUILD_DIR}, which was causing ./scripts/build.sh -c analytical to fail (issue #249).
Changes:
- Remove
cd "${BUILD_DIR}" || exitfromcompile()since each component branch alreadycds into its own build directory.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| mkdir -p "${SIM_LOG_DIR}"/inputs/system/ | ||
| mkdir -p "${SIM_LOG_DIR}"/inputs/workload/ | ||
| mkdir -p "${SIM_LOG_DIR}"/simulation/ | ||
| mkdir -p "${SIM_LOG_DIR}"/config/ | ||
| mkdir -p "${SIM_LOG_DIR}"/topo/ | ||
| mkdir -p "${SIM_LOG_DIR}"/results/ |
There was a problem hiding this comment.
compile() unconditionally creates directories under ${SIM_LOG_DIR} which defaults to /etc/astra-sim. On non-root runs this produces repeated “Permission denied” errors (as in issue #249) and may leave later steps without writable log/result paths. Consider defaulting SIM_LOG_DIR to a user-writable location (e.g., under the repo or $HOME) and/or allowing an env override with a writability check that fails fast with a clear message.
This is causing build.sh script to fail when running: ./scripts/build.sh -c analytical.
Solves issue #249