Skip to content

Fix infinite loop in fix_message_list with multiple tool_calls #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juliosuas wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix infinite loop in fix_message_list with multiple tool_calls #424

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/cai/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1244,9 +1244,19 @@ def fix_message_list(messages): # pylint: disable=R0914,R0915,R0912

# If this isn't the first message, check if the previous message is a matching assistant message
if i > 0:
prev_msg = processed_messages[i - 1]

# Check if the previous message is an assistant message with matching tool_call_id
# Walk backward past sibling tool messages to find the nearest
# assistant. This avoids an infinite loop when an assistant has
# multiple tool_calls and their responses arrive out of order:
# the previous message may be a sibling tool response rather
# than the parent assistant message, which is still valid.
k = i - 1
while k >= 0 and processed_messages[k].get("role") == "tool":
k -= 1

prev_msg = processed_messages[k] if k >= 0 else {}

# Check if the nearest non-tool ancestor is an assistant message
# with a matching tool_call_id
is_valid_sequence = (
prev_msg.get("role") == "assistant"
and prev_msg.get("tool_calls")
Expand Down