shore(CMake): Update minimum version required for new cmake version#257
Conversation
|
Why update the minimum version if it works on the older version? |
|
Hey ! Sorry to not having filled the PR description (tbh I just wanted to fork the repo to make the adaptation for myself, but it could be great to be updated in the main repo anyway) I did this changed cause since CMake 4.0.0, minimum value before 3.5 are not any longer authorized. It is still possible to add a dedicated environment variable to accept lower version. In my case, I was able to update each sub-library I use in my project, EntityX seems to be the only one CMake not updated. Source : https://cmake.org/cmake/help/latest/release/4.0.html#deprecated-and-removed-features Error produced : To be more tolerent, it is possible to set a min...max version with the min the old one and max "3.5". |
|
Aaaah, makes sense, thanks. |
I did this changed cause since CMake 4.0.0, minimum value before 3.5 are not any longer authorized. It is still possible to add a dedicated environment variable to accept lower version. In my case, I was able to update each sub-library I use in my project, EntityX seems to be the only one CMake not updated.
Source : https://cmake.org/cmake/help/latest/release/4.0.html#deprecated-and-removed-features
Error produced :