Update SA.md with character code explanations#61
Update SA.md with character code explanations#61SoTi-AF wants to merge 1 commit intoairframesio:mainfrom
Conversation
Added explanations for various character codes used in the data format.
📝 WalkthroughWalkthroughDocumentation update to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@research/SA.md`:
- Around line 68-72: The mappings for H and E are unresolved and conflict with
the “all current examples” set; update the document by marking H and E as
tentative (e.g., add “(tentative)” after H = HFDL and E = ? or move them into a
new “Unconfirmed mappings” section) or, if you have observed examples, add those
explicit examples showing H and/or E after the time field and remove the
tentative flag; ensure you reference the mapping symbols H and E and preserve
the existing V/2/S entries unchanged.
| V = VDL-M0/A (Plain Old ACARS) | ||
| 2 = VDL-M2 | ||
| S = SATCOM | ||
| H = HFDL | ||
| E = ? |
There was a problem hiding this comment.
Clarify evidence level for H and E mappings.
These mappings conflict with Line 66’s “all current examples” set and E = ? is still unresolved. Please label H/E as tentative (or move them to a separate “unconfirmed” list), or update Line 66 with observed examples that include them after the time field.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@research/SA.md` around lines 68 - 72, The mappings for H and E are unresolved
and conflict with the “all current examples” set; update the document by marking
H and E as tentative (e.g., add “(tentative)” after H = HFDL and E = ? or move
them into a new “Unconfirmed mappings” section) or, if you have observed
examples, add those explicit examples showing H and/or E after the time field
and remove the tentative flag; ensure you reference the mapping symbols H and E
and preserve the existing V/2/S entries unchanged.
Added explanations for various character codes used in the data format.
Summary by CodeRabbit