Pass keyword arguments to SQLAlchemy relationships in SQLModel relationships

[agronholm]

Changes

Fixes #376.

Refactors the API in such a way that lets the SQLModel code generator pass relationship arguments to the underlying SQLAlchemy relationship.

Checklist

If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):

• You've added tests (in tests/) which would fail without your patch
• You've added a new changelog entry (in CHANGES.rst).

If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.

Updating the changelog

If there are no entries after the last release, use **UNRELEASED** as the version.
If, say, your patch fixes issue #123, the entry should look like this:

- Fix big bad boo-boo in task groups
  (`#123 <https://github.com/agronholm/sqlacodegen/issues/123>`_; PR by @yourgithubaccount)

If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.

[coveralls]

coverage: 97.685% (+0.1%) from 97.572%
when pulling d32e4be on fix-sqlmodel-onetomany-multiref
into 4772a34 on master.

[sheinbergon]

I added 2 comments that are mostly cosmetic. Juding by the test, looks like it does what it's supposed to do. Very nice code cleanup

Approved. Do with the comments as you see fit

[sheinbergon]

Just put the new changes in their own dedicated block

[sheinbergon]

Approved again. Resolve the comments as you see fit

[agronholm]

I could do another PR for that migration away from Optional.

[sheinbergon]

I could do another PR for that migration away from Optional.

Sounds great.

[agronholm]

I hit a wrinkle: KeyError: 'SimpleContainers | None' <- this works with 'Optional[SimpleContainers]'. I could try to add from __future__ import annotations but I don't know yet how that will mesh with SQLModel (Pydantic historically reacted badly to deferred annotations).

[agronholm]

I guess they must've made it work since Python 3.14 has that on by default.

[agronholm]

Yeah, this is a no go: sqlalchemy.exc.InvalidRequestError: When initializing mapper Mapper[OtherItems(other_items)], expression 'SimpleOnetoone | None' failed to locate a name ('SimpleOnetoone | None'). If this is a class name, consider adding this relationship() to the <class 'OtherItems'> class after both dependent classes have been defined.

[agronholm]

One would think this stupid issue had been fixed by now but I guess not.

[sheinbergon]

Yeah, this is a no go: sqlalchemy.exc.InvalidRequestError: When initializing mapper Mapper[OtherItems(other_items)], expression 'SimpleOnetoone | None' failed to locate a name ('SimpleOnetoone | None'). If this is a class name, consider adding this relationship() to the <class 'OtherItems'> class after both dependent classes have been defined.

Well, you gave it a try

[agronholm]

Did you want to get something else into the final release?

[sheinbergon]

Did you want to get something else into the final release?

I wanted to run a manual test on the enum arrays before proceeding to 4.0.0 GA. I'll get to it today / tomorrow, and we can proceed to the final release

[sheinbergon]

@agronholm well, it's working. You can go ahead move forward to the 4.0.0 GA. Want to consolidate some release notes in the CHANGES.rst, or just leave it as it is?

[agronholm]

@agronholm well, it's working. You can go ahead move forward to the 4.0.0 GA. Want to consolidate some release notes in the CHANGES.rst, or just leave it as it is?

This is something I haven't really figured out the best practice for. But AFAIK most other projects don't consolidate release notes. You can just make a placeholder release in the changelog and tag the commit, unless you want me to do that.

[sheinbergon]

@agronholm well, it's working. You can go ahead move forward to the 4.0.0 GA. Want to consolidate some release notes in the CHANGES.rst, or just leave it as it is?

This is something I haven't really figured out the best practice for. But AFAIK most other projects don't consolidate release notes. You can just make a placeholder release in the changelog and tag the commit, unless you want me to do that.

I feel that when it comes to phrasing/wording in CHANGES.rst, you have a somewhat specific flavour 😉. So I'd much rather you finalize the release