Handled socket connection broken and added listener#6
Open
palmito9 wants to merge 1 commit intoagalasso:masterfrom
Open
Handled socket connection broken and added listener#6palmito9 wants to merge 1 commit intoagalasso:masterfrom
palmito9 wants to merge 1 commit intoagalasso:masterfrom
Conversation
agalasso
reviewed
Jul 23, 2023
| self.accum_dec = _Accum() | ||
| self.Stats = GuideStats() | ||
| self.Settle = None | ||
| self.eventListener = None if eventListener is None else eventListener |
Owner
There was a problem hiding this comment.
how about this (equivalent and simpler):
Suggested change
| self.eventListener = None if eventListener is None else eventListener | |
| self.eventListener = eventListener |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have made some minor changes in python so it can be used by a third party application for graphing or monitoring PHD2