[docker] Update multi-stage to build the binary on the build platform arch #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… arch This should speed up building, as only the resulting image will use the target arch.
Member
Author
|
Before: After: Both are after another build so caching kicks in so the comparison is more fair. |
BertScholten
approved these changes
Jan 16, 2026
Member
BertScholten
left a comment
BertScholten
left a comment
There was a problem hiding this comment.
ACK (though do wonder what happens if BUILDPLATFORM is not specified)
Member
Author
These are provided by Docker bake (buildx) itself I believe. For it not to be set, you'd need to use a very old version, but as this uses our github-actions, which enforces bake (buildx) with multi-platform support, it shouldn't be an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should speed up building, as only the resulting image will use the target arch.