AER-4255 Extended HexagonUtil to add custom rounding parameter for hexagon coordinates.#369
Open
Hilbrand wants to merge 1 commit intoaerius:mainfrom
Open
AER-4255 Extended HexagonUtil to add custom rounding parameter for hexagon coordinates.#369Hilbrand wants to merge 1 commit intoaerius:mainfrom
Hilbrand wants to merge 1 commit intoaerius:mainfrom
Conversation
…xagon coordinates. Kept original method for backward compatibility.
BertScholten
requested changes
Feb 6, 2026
| /** | ||
| * Returns a Geometry with a hexagon conforming to the given Point, and rounds the points of the hexagon | ||
| * | ||
| * @see #createHexagon(Point, HexagonZoomLevel, boolean) |
Member
There was a problem hiding this comment.
Suggested change
| * @see #createHexagon(Point, HexagonZoomLevel, boolean) | |
| * @see #createHexagon(Point, HexagonZoomLevel, DoubleUnaryOperator) |
| assertCreateHexagon(); | ||
| @ParameterizedTest | ||
| @MethodSource("createHexagon") | ||
| void testCreateHexagon(final boolean round, final double[][][] results) { |
Member
There was a problem hiding this comment.
useDefaultMethod might make more sense as a parameter?
| final Polygon polygon = round | ||
| ? HexagonUtil.createHexagon(point, ZOOM_LEVEL_1) | ||
| : HexagonUtil.createHexagon(point, ZOOM_LEVEL_1, d -> BigDecimal.valueOf(d).setScale(3, RoundingMode.HALF_UP).doubleValue()); | ||
| System.out.println(polygon); |
| */ | ||
| package nl.overheid.aerius.shared.domain.geo; | ||
|
|
||
| import nl.overheid.aerius.shared.MathUtil; |
Member
There was a problem hiding this comment.
Don't know if the reason stated in MathUtil for using it over Math.round still applies?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kept original method for backward compatibility.