Fix CSS for mobile browsers and various html/body targeting libraries#257
Open
JoryHogeveen wants to merge 2 commits intoadchsm:masterfrom
Open
Fix CSS for mobile browsers and various html/body targeting libraries#257JoryHogeveen wants to merge 2 commits intoadchsm:masterfrom
JoryHogeveen wants to merge 2 commits intoadchsm:masterfrom
Conversation
JoryHogeveen
added a commit
to JoryHogeveen/off-canvas-sidebars
that referenced
this pull request
Oct 5, 2016
- See adchsm/Slidebars#257 - See https://www.adchsm.com/slidebars/help/advanced-usage/scrolling-the-html-or-body-elements/ - See https://wordpress.org/support/topic/conflict-with-off-canvas-sidebars/ - Addresses scroll lock aswell
12 tasks
|
👍 |
|
Thanks. This solved my issue #277 EDIT: Looks like it breaks smoothscroll to #anchors EDIT2: Looks like a more traditional smooth scroll approach works. :) |
Author
|
@NoLooseEnds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #251
Related: #292
Todo
z-index: 0;)