Read version from use-node-version key of .npmrc#1149
Read version from use-node-version key of .npmrc#1149mcevoypeter wants to merge 3 commits intoactions:mainfrom
Conversation
|
@aparnajyothi-y for visibility |
|
@aparnajyothi-y , gentle bump on this :) |
|
We would love to be able to drop |
|
@aparnajyothi-y, bumping this again :) I'd love to get this in if my changes look good to you |
|
@aparnajyothi-y, seems like you're quite busy. Is there someone else I should be seeking a review from? |
|
I'd love to see this too! @aparnajyothi-y or @priya-kinthali, any chance we can nudge you to review this PR? |
6f7d311 to
c9b99bb
Compare
c9b99bb to
b0f1a15
Compare
|
@aparnajyothi-y or @priya-kinthali, any chance we can nudge you to review this PR? If not, can you suggest another reviewer with bandwidth? |
|
Hi @aparnajyothi-y or @priya-kinthali, could I trouble you to review this PR? I'd greatly appreciate it! |
There was a problem hiding this comment.
maybe instead install @types/ini?
There was a problem hiding this comment.
ini does not have any dependencies so it shouldn't change the package-lock.json i believe
There was a problem hiding this comment.
is it normal that this number of changes are made? seems like quite a red flag
|
Hello Everyone, Thank you for this pull request. We are looking into it and get back to you once we have some feedback on this :) |
@mcevoypeter - I forked your PR to confirm what @PeterCardenas commented. Change to the lock file and dist directory are much more reasonable: https://github.com/actions/setup-node/pull/1253/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519. All I did was restore the lockfile, add @types/init and rebuild. Feel free to cherry pick the last commit. |
hi @aparnajyothi-y, I had a little time today so I went ahead and fixed up a few of the issue with this PR and created: #1253. Please take a look when you have a chance! |
Description:
Add support for determining the Node version from the
use-node-versionkey of.npmrcas described in the PNPM docs.Related issue:
Resolves #1130
Check list: