Skip to content

Bump hook to 0.8.1#4222

Open
nikola-jokic wants to merge 1 commit intoactions:mainfrom
nikola-jokic:nikola-jokic/hook-0.8.1
Open

Bump hook to 0.8.1#4222
nikola-jokic wants to merge 1 commit intoactions:mainfrom
nikola-jokic:nikola-jokic/hook-0.8.1

Conversation

@nikola-jokic
Copy link
Contributor

No description provided.

@nikola-jokic nikola-jokic requested a review from a team as a code owner February 4, 2026 12:02
Copilot AI review requested due to automatic review settings February 4, 2026 12:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the runner-container-hooks version from 0.8.0 to 0.8.1 for the k8s-novolume installation.

Changes:

  • Bumps the hardcoded runner-container-hooks version from 0.8.0 to 0.8.1 in the Dockerfile

&& rm runner-container-hooks.zip

RUN curl -f -L -o runner-container-hooks.zip https://github.com/actions/runner-container-hooks/releases/download/v0.8.0/actions-runner-hooks-k8s-0.8.0.zip \
RUN curl -f -L -o runner-container-hooks.zip https://github.com/actions/runner-container-hooks/releases/download/v0.8.1/actions-runner-hooks-k8s-0.8.1.zip \
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This creates an inconsistency in runner-container-hooks versions. The k8s directory (line 20) uses RUNNER_CONTAINER_HOOKS_VERSION which is set to 0.7.0, while k8s-novolume now uses 0.8.1. Consider either:

  1. Updating RUNNER_CONTAINER_HOOKS_VERSION to 0.8.1 and using it for both installations
  2. Creating a separate ARG for the k8s-novolume version if the different versions are intentional
  3. Documenting why different versions are needed if this is by design

Having different versions without clear justification makes maintenance harder and could lead to unexpected behavior differences.

Copilot uses AI. Check for mistakes.
&& rm runner-container-hooks.zip

RUN curl -f -L -o runner-container-hooks.zip https://github.com/actions/runner-container-hooks/releases/download/v0.8.0/actions-runner-hooks-k8s-0.8.0.zip \
RUN curl -f -L -o runner-container-hooks.zip https://github.com/actions/runner-container-hooks/releases/download/v0.8.1/actions-runner-hooks-k8s-0.8.1.zip \
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This curl + unzip pattern downloads runner-container-hooks.zip from a GitHub Releases tag and immediately extracts it without any checksum or signature verification, creating a supply-chain risk if the actions/runner-container-hooks release or tag is ever compromised. An attacker who can tamper with that release asset (or the tag it’s built from) could deliver malicious hooks that get baked into every built runner image. To mitigate this, pin the download to an immutable identifier (e.g., a commit SHA or exact asset hash) and verify the archive’s integrity (checksum or signature) before unzipping.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant