Conversation
| && rm runner-container-hooks.zip | ||
|
|
||
| RUN curl -f -L -o runner-container-hooks.zip https://github.com/actions/runner-container-hooks/releases/download/v0.8.0/actions-runner-hooks-k8s-0.8.0.zip \ | ||
| RUN curl -f -L -o runner-container-hooks.zip https://github.com/actions/runner-container-hooks/releases/download/v0.8.1/actions-runner-hooks-k8s-0.8.1.zip \ |
There was a problem hiding this comment.
This creates an inconsistency in runner-container-hooks versions. The k8s directory (line 20) uses RUNNER_CONTAINER_HOOKS_VERSION which is set to 0.7.0, while k8s-novolume now uses 0.8.1. Consider either:
- Updating RUNNER_CONTAINER_HOOKS_VERSION to 0.8.1 and using it for both installations
- Creating a separate ARG for the k8s-novolume version if the different versions are intentional
- Documenting why different versions are needed if this is by design
Having different versions without clear justification makes maintenance harder and could lead to unexpected behavior differences.
| && rm runner-container-hooks.zip | ||
|
|
||
| RUN curl -f -L -o runner-container-hooks.zip https://github.com/actions/runner-container-hooks/releases/download/v0.8.0/actions-runner-hooks-k8s-0.8.0.zip \ | ||
| RUN curl -f -L -o runner-container-hooks.zip https://github.com/actions/runner-container-hooks/releases/download/v0.8.1/actions-runner-hooks-k8s-0.8.1.zip \ |
There was a problem hiding this comment.
This curl + unzip pattern downloads runner-container-hooks.zip from a GitHub Releases tag and immediately extracts it without any checksum or signature verification, creating a supply-chain risk if the actions/runner-container-hooks release or tag is ever compromised. An attacker who can tamper with that release asset (or the tag it’s built from) could deliver malicious hooks that get baked into every built runner image. To mitigate this, pin the download to an immutable identifier (e.g., a commit SHA or exact asset hash) and verify the archive’s integrity (checksum or signature) before unzipping.
No description provided.