Add telemetry tracking for deprecated set-output and save-state commands#4221
Open
ericsciple wants to merge 1 commit intomainfrom
Open
Add telemetry tracking for deprecated set-output and save-state commands#4221ericsciple wants to merge 1 commit intomainfrom
ericsciple wants to merge 1 commit intomainfrom
Conversation
- Add HasDeprecatedSetOutput and HasDeprecatedSaveState flags to GlobalContext - Emit JobTelemetry once per job when deprecated commands are used - Add unit tests verifying once-per-job telemetry behavior
ericsciple
force-pushed
the
users/ericsciple/26-02-setoutput
branch
from
94e3855 to
9167ce7
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds telemetry tracking to detect usage of deprecated GitHub Actions commands (set-output and save-state). The implementation ensures telemetry is emitted only once per job when these deprecated commands are used, preventing duplicate telemetry entries.
Changes:
- Added boolean flags to track first usage of deprecated commands in GlobalContext
- Implemented telemetry emission logic that checks flags before adding telemetry entries
- Added unit tests to verify once-per-job telemetry emission behavior
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Runner.Worker/GlobalContext.cs | Added HasDeprecatedSetOutput and HasDeprecatedSaveState boolean properties to track command usage |
| src/Runner.Worker/ActionCommandManager.cs | Implemented telemetry emission logic with flag checks for both deprecated commands |
| src/Test/L0/Worker/ActionCommandManagerL0.cs | Added command extensions to test setup and created unit tests verifying single telemetry emission per command type |
Collaborator
Author
|
Tested E2E |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.