[installdependencies.sh] refactor: support microdnf, handle .deb installation errors#4040
Open
konstruktoid wants to merge 15 commits intoactions:mainfrom
Open
[installdependencies.sh] refactor: support microdnf, handle .deb installation errors#4040konstruktoid wants to merge 15 commits intoactions:mainfrom
microdnf, handle .deb installation errors#4040konstruktoid wants to merge 15 commits intoactions:mainfrom
Conversation
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the dependency installation script to improve reliability, modernize package manager support, and handle errors more gracefully. The changes focus on better error handling, broader package manager compatibility, and updated dependency lists.
Key changes:
- Added strict error handling with
set -e -o pipefailand improved conditional checks - Consolidated RedHat-based package manager detection to support
dnf,yum, andmicrodnf - Updated dependency lists to include newer library versions (libssl3, libicu74/73)
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
dnfcode, sincednfhas basically replacedyumon all RedHat variantsmicrodnf, used by eg minimal RockyLinux imagesInstallation test logs are available at https://gist.github.com/konstruktoid/438fa3abdaf787b3e5bcd36935764f0d