#226: Added a better Workflow Pod readiness check#259
Open
andrei-shershukov wants to merge 3 commits intoactions:mainfrom
Open
#226: Added a better Workflow Pod readiness check#259andrei-shershukov wants to merge 3 commits intoactions:mainfrom
andrei-shershukov wants to merge 3 commits intoactions:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Enhances the Workflow Pod readiness check by implementing a more comprehensive state validation system that checks both pod phases and conditions before executing workflow jobs.
- Introduces
PodConditionenum with comprehensive pod condition types - Adds new
waitForPodStateandwaitForPodToBeReadyfunctions for enhanced readiness validation - Replaces basic phase-only checking with combined phase and condition validation in
runContainerStep
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/k8s/src/k8s/utils.ts | Adds PodCondition enum defining Kubernetes pod condition types |
| packages/k8s/src/k8s/index.ts | Implements enhanced pod state checking functions with condition validation |
| packages/k8s/src/hooks/run-container-step.ts | Updates container step execution to use improved readiness check |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enchants the Workflow Pod readiness check by ensuring the proper phase and state of the Pod. This check is running during the
runContainerStep. This enables us to run status and readiness probe checks of the containers before executing the workflow job, ensuring the true readiness of the running containers and removing potential issues. It will also allow users to run scripts before the workflow job begins, such as running a DinD sidecar container and waiting for it to launch the daemon via the startup or readiness container probes.