Skip to content

fix: handle zero swap tx gas value in 'executeSwapQuote' #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gabrielstoica wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: handle zero swap tx gas value in 'executeSwapQuote' #257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 51 additions & 51 deletions packages/sdk/src/actions/executeSwapQuote.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,68 +13,68 @@ export type SwapExecutionProgress = SwapTransactionProgress;

type SwapTransactionProgress =
| {
step: "approve";
status: "idle";
}
step: "approve";
status: "idle";
}
| {
step: "approve";
status: "simulationPending";
}
step: "approve";
status: "simulationPending";
}
| {
step: "approve";
status: "simulationSuccess";
}
step: "approve";
status: "simulationSuccess";
}
| {
step: "approve";
status: "txPending";
txHash: Hash;
}
step: "approve";
status: "txPending";
txHash: Hash;
}
| {
step: "approve";
status: "txSuccess";
txReceipt: TransactionReceipt;
}
step: "approve";
status: "txSuccess";
txReceipt: TransactionReceipt;
}
| {
step: "swap";
status: "idle";
}
step: "swap";
status: "idle";
}
| {
step: "swap";
status: "simulationPending";
}
step: "swap";
status: "simulationPending";
}
| {
step: "swap";
status: "simulationSuccess";
}
step: "swap";
status: "simulationSuccess";
}
| {
step: "swap";
status: "txPending";
txHash: Hash;
}
step: "swap";
status: "txPending";
txHash: Hash;
}
| {
step: "swap";
status: "txSuccess";
txReceipt: TransactionReceipt;
depositId: bigint;
depositLog: ReturnType<typeof parseDepositLogs>;
}
step: "swap";
status: "txSuccess";
txReceipt: TransactionReceipt;
depositId: bigint;
depositLog: ReturnType<typeof parseDepositLogs>;
}
| {
step: "fill";
status: "txPending";
}
step: "fill";
status: "txPending";
}
| {
step: "fill";
status: "txSuccess";
txReceipt: TransactionReceipt;
fillTxTimestamp: bigint;
actionSuccess: boolean | undefined;
fillLog: ReturnType<typeof parseFillLogs>;
}
step: "fill";
status: "txSuccess";
txReceipt: TransactionReceipt;
fillTxTimestamp: bigint;
actionSuccess: boolean | undefined;
fillLog: ReturnType<typeof parseFillLogs>;
}
| {
step: "approve" | "swap" | "fill";
status: "txError" | "error" | "simulationError";
error: Error;
};
step: "approve" | "swap" | "fill";
status: "txError" | "error" | "simulationError";
error: Error;
};

/**
* Params for {@link executeSwapQuote}.
Expand Down Expand Up @@ -269,7 +269,7 @@ export async function executeSwapQuote(
to: swapTx.to as Address,
data: swapTx.data as Hex,
value: swapTx.value ? BigInt(swapTx.value) : 0n,
gas: swapTx.gas ? BigInt(swapTx.gas) : undefined,
gas: swapTx.gas && BigInt(swapTx.gas) > 0n ? BigInt(swapTx.gas) : undefined,
maxFeePerGas: swapTx.maxFeePerGas
? BigInt(swapTx.maxFeePerGas)
: undefined,
Expand Down