Open
Conversation
MontrealSergiy
force-pushed
the
upload_dp_err2
branch
from
8bced40 to
b7fc5f3
Compare
prioux
requested changes
Sep 30, 2025
| data_provider_id = params[:data_provider_id] | ||
| data_provider_id = params[:data_provider_id] | ||
|
|
||
| DataProvider.find_accessible_by_user(data_provider_id, current_user) |
Member
There was a problem hiding this comment.
Please add a comment line just above this new line, something like:
# Verify that the DP is accessible to the user; this will raise an exception otherwise| allow(Message).to receive(:send_message) | ||
| allow(File).to receive(:delete) | ||
| allow(controller).to receive(:system) | ||
| allow(DataProvider).to receive(:find_accessible_by_user).and_return([data_provider]) |
Member
There was a problem hiding this comment.
Shouldn't this be:
and_return(data_provider)(Not an array with the DP, a single DP object)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An alternative or perhaps complimentary bugfix at upload to wrong dp id
I'd merge this one and #1545 just in the case - it is quite possible the model issue may manifest itself in some other context