feat(ui-markdown-editor): Implemented Code Block#380
Open
d-e-v-esh wants to merge 1 commit intoaccordproject:mainfrom
Open
feat(ui-markdown-editor): Implemented Code Block#380d-e-v-esh wants to merge 1 commit intoaccordproject:mainfrom
d-e-v-esh wants to merge 1 commit intoaccordproject:mainfrom
Conversation
Signed-off-by: Devesh <deves125@gmail.com>
dselman
requested changes
Feb 22, 2022
Contributor
dselman
left a comment
There was a problem hiding this comment.
You can apply styling inside the code block (e.g. bold/italic). If you apply list formatting the editor crashes.
Contributor
Author
|
@dselman It is only crashing on the deploy preview for some reason, it does not crash in the local build. What could be the reason for this? Does the crash error give any hints? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Signed-off-by: Devesh deves125@gmail.com
Closes #30
This PR builds on top of #289 and solves some of the problems that it had
i.e. enter key problem, text crossing the border of the code block
Changes
Flags
Screenshots or Video
Related Issues
Author Checklist
--signoffoption of git commit.masterfromfork:branchname