fix: resolve PID validation, stack trace handling, and queue overflow…#121
Open
Sana9058 wants to merge 1 commit intoaccordproject:mainfrom
Open
fix: resolve PID validation, stack trace handling, and queue overflow…#121Sana9058 wants to merge 1 commit intoaccordproject:mainfrom
Sana9058 wants to merge 1 commit intoaccordproject:mainfrom
Conversation
… issues in JavaScriptEvaluator (accordproject#109) Signed-off-by: apple <apple@apples-MacBook-Pro.local>
Sana9058
force-pushed
the
fix/javascript-evaluator-bugs-clean
branch
from
8d8ff60 to
0106071
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issues reported in #109 related to the JavaScriptEvaluator.
Summary of Fixes:
Fixed incorrect PID validation
Updated the PID validation logic to ensure valid processes are not rejected due to falsy values such as 0.
Improved stack trace handling
Ensured that error stack traces are preserved instead of being swallowed, making debugging easier.
Prevented queue overflow race condition
Added proper queue length validation to prevent exceeding maxQueueDepth during concurrent operations.
Motivation:
These fixes improve the reliability and debugging clarity of the JavaScriptEvaluator by ensuring correct process validation, better error reporting, and safer queue management.
Notes:
Please let me know if any changes or restructuring are required.