feat: add URL query parameter for wallet selection#2721
Open
AndreMiras wants to merge 1 commit intoaave:mainfrom
Open
feat: add URL query parameter for wallet selection#2721AndreMiras wants to merge 1 commit intoaave:mainfrom
AndreMiras wants to merge 1 commit intoaave:mainfrom
Conversation
Implements support for viewing wallet positions via URL query parameters (e.g., app.aave.com/dashboard/?wallet=0xAddress or ?wallet=vitalik.eth). Features: - URL parameter takes precedence over localStorage - ENS name resolution with async handling - Silent fallback for invalid addresses Known limitations: - Auto-disconnect of connected wallet not implemented in this version - Users should disconnect wallet manually before using URL parameter Closes aave#2331
|
@AndreMiras is attempting to deploy a commit to the Avara Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements support for viewing wallet positions via URL query parameters (e.g., app.aave.com/dashboard/?wallet=0xAddress or ?wallet=vitalik.eth).
Features:
Known limitations:
Closes #2331
General Changes
Developer Notes
Add any notes here that may be helpful for reviewers.
Reviewer Checklist
Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.
.env.examplefile as well as the pertinant.github/actions/*files