Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: The
_run_gitfunction insrc/scanner/git_ops.pytook user-controlled strings (like repository URLs or branch names) and placed them directly intogitCLI commands without validation or delimiting. If a user provided an argument like--upload-pack=maliciousas a repository URL, Git would interpret it as a command option instead of a positional argument. This commit adds a validation step (_validate_no_options) to prevent string arguments starting with-from reaching thegitcommand, and explicitly appends--forgit cloneto separate options from positional arguments correctly.clone_repoorpull_latestfunctions.🛡️ Solution:
_validate_no_optionshelper that checks if user-supplied strings begin with-and raises aValueErrorif so.git clonecommand inclone_repoto append--right before the positional arguments (repo_urlandlocal_path). (Note:--was specifically avoided ingit pullandgit checkoutas they misinterpret it due to how those commands parse pathspecs/refs).PR created automatically by Jules for task 12344443644230307895 started by @ishaanxgupta