Refactor embedding logic to shared utility to fix circular dependency#43
Refactor embedding logic to shared utility to fix circular dependency#43ishaanxgupta wants to merge 1 commit intomainfrom
Conversation
Extracted `embed_text` logic from `src/pipelines/ingest.py` to `src/utils/embeddings.py` to resolve circular dependency with `src/storage/pinecone.py`. Changes: - Created `src/utils/embeddings.py` with `embed_text` and `get_embedding_client`. - Updated `src/pipelines/ingest.py`, `src/storage/pinecone.py`, and `src/pipelines/retrieval.py` to use the new utility. - Added `tests/unit/utils/test_embeddings.py` to verify the new utility. - Verified all changes with `ruff` and unit tests.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Extracted
embed_textlogic fromsrc/pipelines/ingest.pytosrc/utils/embeddings.pyto resolve circular dependency withsrc/storage/pinecone.py.Changes:
src/utils/embeddings.pywithembed_textandget_embedding_client.src/pipelines/ingest.py,src/storage/pinecone.py, andsrc/pipelines/retrieval.pyto use the new utility.tests/unit/utils/test_embeddings.pyto verify the new utility.ruffand unit tests.PR created automatically by Jules for task 7571175948543949607 started by @ishaanxgupta