Skip to content

Refactor embedding logic to shared utility to fix circular dependency#43

Draft
ishaanxgupta wants to merge 1 commit intomainfrom
refactor-embeddings-circular-dependency-7571175948543949607
Draft

Refactor embedding logic to shared utility to fix circular dependency#43
ishaanxgupta wants to merge 1 commit intomainfrom
refactor-embeddings-circular-dependency-7571175948543949607

Conversation

@ishaanxgupta
Copy link
Member

Extracted embed_text logic from src/pipelines/ingest.py to src/utils/embeddings.py to resolve circular dependency with src/storage/pinecone.py.

Changes:

  • Created src/utils/embeddings.py with embed_text and get_embedding_client.
  • Updated src/pipelines/ingest.py, src/storage/pinecone.py, and src/pipelines/retrieval.py to use the new utility.
  • Added tests/unit/utils/test_embeddings.py to verify the new utility.
  • Verified all changes with ruff and unit tests.

PR created automatically by Jules for task 7571175948543949607 started by @ishaanxgupta

Extracted `embed_text` logic from `src/pipelines/ingest.py` to `src/utils/embeddings.py` to resolve circular dependency with `src/storage/pinecone.py`.

Changes:
- Created `src/utils/embeddings.py` with `embed_text` and `get_embedding_client`.
- Updated `src/pipelines/ingest.py`, `src/storage/pinecone.py`, and `src/pipelines/retrieval.py` to use the new utility.
- Added `tests/unit/utils/test_embeddings.py` to verify the new utility.
- Verified all changes with `ruff` and unit tests.
@google-labs-jules
Copy link

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant