Merged
Conversation
Contributor
Irwin1985
commented
Mar 7, 2026
- Added Environment.UserInteractive check to immediately fallback in non-UI environments (Services, IIS, etc).
- Refined LoadProvider to use physical file detection instead of AppDomain assembly checks to overcome .NET JIT Lazy Loading issues.
- Ensured MESSAGEBOX() and other UI functions triggered automatically if XSharp.VFP.UI.dll is present.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the VFP UI provider loading mechanism in VfpUIService. The key improvement is an early-exit guard that prevents UI DLL loading in non-interactive environments (Windows Services, IIS), and cleans up the DLL detection logic by switching from AppDomain assembly checks to physical file existence checks.
Changes:
- Added
Environment.UserInteractivecheck to immediately assignHeadlessUIProviderin non-interactive environments, avoiding unnecessary DLL discovery and loading - Refactored
LOCAL ... AS TYPEvariable declarations toVARinference withinLoadProvider()for brevity
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.