Skip to content

Add Deployment Precheck feature#355

Open
Wiesenwischer wants to merge 3 commits intomainfrom
feature/deployment-precheck-domain
Open

Add Deployment Precheck feature#355
Wiesenwischer wants to merge 3 commits intomainfrom
feature/deployment-precheck-domain

Conversation

@Wiesenwischer
Copy link
Copy Markdown
Owner

Summary

  • Add deployment precheck system that validates deployments before execution (image availability, port conflicts, volume status, network availability, existing deployments, variable validation)
  • Domain model with PrecheckResult, PrecheckItem, and PrecheckSeverity value objects; application layer with pluggable IDeploymentPrecheckRule rules and RunDeploymentPrecheckQuery
  • Infrastructure rules for Docker-level checks (image pull, port binding, volume mounts, network existence)
  • UI integration: PrecheckPanel component in deploy flow with re-check and severity indicators
  • Documentation (DE/EN) with E2E tests and screenshots

Test plan

  • Unit tests for all precheck rules (ExistingDeployment, ImageAvailability, PortConflict, VolumeStatus)
  • Domain tests for PrecheckResult aggregation logic
  • E2E test spec for deployment precheck UI flow
  • Manual: trigger precheck via deploy flow, verify results display correctly
  • Manual: verify Cloudflare Pages preview deployment for documentation changes

Pre-flight checks before deployment to verify infrastructure readiness
before the point of no return (container removal).

Domain: PrecheckResult, PrecheckItem, PrecheckSeverity value objects
Rules: 6 precheck rules (ImageAvailability, PortConflict, VariableValidation,
  NetworkAvailability, VolumeStatus, ExistingDeployment)
API: POST /api/environments/{envId}/stacks/{stackId}/precheck endpoint
Hooks: Automatic precheck before hook deploys, dryRun parameter, 422 on errors
UI: PrecheckPanel component, auto-run on deploy flow entry, Re-Check button,
  deploy button disabled when precheck has errors
Tests: 53 unit tests covering all rules, result aggregation, and edge cases
- Add E2E test suite (6 tests) covering precheck panel, severity icons,
  re-check button, deploy button state, loading state, and custom deploy
- Capture 6 screenshots for step-by-step documentation
- Add German and English docs pages under deployments/deployment-precheck
- Update docs index pages with precheck links
- Add Deployment Precheck as highlighted feature on landing page with
  NEW badge, translations (DE/EN), and shield-check icon
@github-actions github-actions bot added documentation Improvements or additions to documentation feature New feature or enhancement labels Apr 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

🚀 Cloudflare Pages Preview

Preview deployment ready!

URL: https://10653a01.readystackgo.pages.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation feature New feature or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant