Conversation
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
danleh
left a comment
danleh
left a comment
There was a problem hiding this comment.
LGTM with some nits and questions.
| } | ||
| }); | ||
| const idSet = new Set(ids); | ||
| await driver.get( `http://localhost:${PORT}/index.html?tags=all`); |
There was a problem hiding this comment.
Do we want to force documentation for all workloads, even the non-default ones? I would prefer to just document the default ones, otherwise people might be confused why they are listed in in-depth.html but missing from the benchmark run.
There was a problem hiding this comment.
Or maybe grey the non-default ones out? Something like: <dt class="non-default">...</dt> with CSS
dt .non-default:after {
color: #666
}
dt .non-default:after {
content: " (not run by default)";
}
There was a problem hiding this comment.
For easier reviewing: is this just reformatted or also adding new information?
| } | ||
|
|
||
| async function inDepthPageTest(driver) { | ||
| await driver.get( `http://localhost:${PORT}/in-depth.html`); |
|
|
||
| async function testEnd2End(params) { | ||
| async function runBrowserDriver(body) { | ||
| const builder = new Builder().withCapabilities(capabilities); |
There was a problem hiding this comment.
nit: double space (maybe just reformat?)
2 participants
First steps to address #199.