Remove 'settings' directory which includes 'settings.py' file#110
Open
gb0101010101 wants to merge 1 commit intoWebControlCNC:masterfrom
Open
Remove 'settings' directory which includes 'settings.py' file#110gb0101010101 wants to merge 1 commit intoWebControlCNC:masterfrom
gb0101010101 wants to merge 1 commit intoWebControlCNC:masterfrom
Conversation
…ry which includes 'settings.py' file. This does not appear to be used anymore and has been replaced by 'config/config.py' using 'defaultwebcontrol.json' and 'webcontrol.json'.
Contributor
Author
|
Can anyone confirm these files are no longer used? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This file and directory do not appear to be used anymore. They look to have been replaced by 'config/config.py' using 'defaultwebcontrol.json' and 'webcontrol.json'.
Searched code for:
Tested:
No errors reported and everything worked.
Think it is safe to delete this.