Add support for "verified" clients.#25
Open
TimothyBJacobs wants to merge 1 commit intodynamic-client-registrationfrom
Open
Add support for "verified" clients.#25TimothyBJacobs wants to merge 1 commit intodynamic-client-registrationfrom
TimothyBJacobs wants to merge 1 commit intodynamic-client-registrationfrom
Conversation
This checks the JWT for an "iss" header. If one is present, we fetch a public key at that host ".well-known/wp-api/oauth2.pem", and use that public key to verify the JWT. If a client is verified we display a "verified" message on the connect screen. This also adds a new "--sign" flag to the CLI command to generate a signed software statement. Fixes #18.
Member
Author
|
Right now we're assuming that the site has OpenSSL available. We should check that and not attempt signing if it isn't available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First pass at a basic form of verified software statements.
This checks the JWT for an "iss" header. If one is present, we fetch a public key at that host ".well-known/wp-api/oauth2.pem", and use that public key to verify the JWT.
If a client is verified we display a "verified" message on the connect screen.
This also adds a new "--sign" flag to the CLI command to generate a signed software statement.
Fixes #18.
Test Instructions
And upload it to
https://yourwebsite.com/.well-known/wp-api/oauth2.pem.Then, in your WordPress install run the WP CLI command to generate a software statement.
WP CLI will prompt you for the passphrase you entered in step 1.
Use your generated software statement as the
client_id.