fix(apollo-react): stage title input fills available header width [MST-7791]#384
fix(apollo-react): stage title input fills available header width [MST-7791]#384KodudulaAshishUiPath wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency License Review
License distribution
Excluded packages
|
There was a problem hiding this comment.
Pull request overview
Fixes the stage header title editing UX in apollo-react by allowing the stage title input to expand and use the available header width.
Changes:
- Make the left header layout flexible (
flex=1,minW=0) so the title region can grow/shrink correctly. - Update stage title container/input styles to be full-width and remove the prior max-width constraint.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/apollo-react/src/canvas/components/StageNode/StageNode.tsx | Adjusts header layout flex behavior so the title area can take remaining space. |
| packages/apollo-react/src/canvas/components/StageNode/StageNode.styles.ts | Makes the title container/input full-width to fill available header width. |
| display: block; | ||
| border-radius: 4px; | ||
| height: 100%; | ||
| width: 100%; |
There was a problem hiding this comment.
StageTitleContainer is now width: 100% and conditionally adds a 1px border. Without box-sizing: border-box, the border increases the rendered width beyond 100%, which can cause the title area to overflow/clamp inside StageHeader (which has overflow: hidden) and visually clip the border when editing. Consider adding box-sizing: border-box (and/or moving the border to an inner element) so the container remains within the available width when the border is applied.
| width: 100%; | |
| width: 100%; | |
| box-sizing: border-box; |
| width: 100%; | ||
| min-width: 100px; | ||
| max-width: 220px; | ||
| padding: ${(props) => (props.isStageTitleEditable ? 'none' : `${Padding.PadS} 0px`)}; |
There was a problem hiding this comment.
padding: none is not a valid CSS value, so when isStageTitleEditable is true this rule will be dropped and the input will fall back to the browser default padding. Use a valid value like 0/0px (or the appropriate token-based padding) to ensure consistent sizing, especially now that the input is intended to fill the available width.
| padding: ${(props) => (props.isStageTitleEditable ? 'none' : `${Padding.PadS} 0px`)}; | |
| padding: ${(props) => (props.isStageTitleEditable ? '0' : `${Padding.PadS} 0px`)}; |
There was a problem hiding this comment.
although this is unrelated to the PR, can we fix this as well?
|
Did you test the inline edit behaviour? |
f11df8a to
efcd4ed
Compare
Yes, I have added a story as well to test inline edit behaviour |
Description
Demo
Before
Screen.Recording.2026-03-23.at.15.16.55.mov
After
Screen.Recording.2026-03-23.at.15.25.01.mov