Skip to content

fix(apollo-react): preserve task order when creating parallel group with task below [MST-7790]#383

Merged
SreedharAvvari merged 1 commit intomainfrom
fix/MST-7790
Mar 23, 2026
Merged

fix(apollo-react): preserve task order when creating parallel group with task below [MST-7790]#383
SreedharAvvari merged 1 commit intomainfrom
fix/MST-7790

Conversation

@SreedharAvvari
Copy link
Contributor

@SreedharAvvari SreedharAvvari commented Mar 23, 2026

Before

image.2026-03-23.at.11.15.28.AM.mov

After

image.2026-03-23.at.11.14.13.AM.mov

Copilot AI review requested due to automatic review settings March 23, 2026 05:00
@github-actions
Copy link

github-actions bot commented Mar 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (PT)
apollo-canvas 🟢 Ready Preview, Logs Mar 22, 2026, 10:04:44 PM
apollo-landing 🟢 Ready Preview, Logs Mar 22, 2026, 10:01:51 PM
apollo-ui-react 🟢 Ready Preview, Logs Mar 22, 2026, 10:03:49 PM
apollo-vertex 🟢 Ready Preview, Logs Mar 22, 2026, 10:02:59 PM
apollo-wind 🟢 Ready Preview, Logs Mar 22, 2026, 10:02:44 PM

@github-actions
Copy link

Dependency License Review

  • 1916 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 3 package(s) excluded (see details below)
License distribution
License Packages
MIT 1681
ISC 89
Apache-2.0 56
BSD-3-Clause 28
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 5
MIT OR Apache-2.0 3
MIT-0 3
CC0-1.0 3
LGPL-3.0-or-later 2
(MIT OR Apache-2.0) 2
Unlicense 2
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.2.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
@img/sharp-libvips-linuxmusl-x64 1.2.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes task ordering when merging a task into the parallel group below, ensuring the moved task preserves its original relative position (above the tasks it’s merged with) in the resulting group.

Changes:

  • Update mergeGroupDown to prepend the moved task to the group below (instead of appending).
  • Adjust unit tests to assert the new, order-preserving merge behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/apollo-react/src/canvas/utils/GroupModificationUtils.ts Changes mergeGroupDown to place the moved task before the below group’s existing tasks to preserve order.
packages/apollo-react/src/canvas/utils/GroupModificationUtils.test.ts Updates expectations for mergeGroupDown tests to match the corrected ordering behavior.

@SreedharAvvari SreedharAvvari merged commit c65fa2b into main Mar 23, 2026
36 checks passed
@SreedharAvvari SreedharAvvari deleted the fix/MST-7790 branch March 23, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants