fix(apollo-react): preserve task order when creating parallel group with task below [MST-7790]#383
Merged
SreedharAvvari merged 1 commit intomainfrom Mar 23, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency License Review
License distribution
Excluded packages
|
There was a problem hiding this comment.
Pull request overview
Fixes task ordering when merging a task into the parallel group below, ensuring the moved task preserves its original relative position (above the tasks it’s merged with) in the resulting group.
Changes:
- Update
mergeGroupDownto prepend the moved task to the group below (instead of appending). - Adjust unit tests to assert the new, order-preserving merge behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/apollo-react/src/canvas/utils/GroupModificationUtils.ts | Changes mergeGroupDown to place the moved task before the below group’s existing tasks to preserve order. |
| packages/apollo-react/src/canvas/utils/GroupModificationUtils.test.ts | Updates expectations for mergeGroupDown tests to match the corrected ordering behavior. |
kittyyueli
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
image.2026-03-23.at.11.15.28.AM.mov
After
image.2026-03-23.at.11.14.13.AM.mov