feat(apollo-vertex): update Alert and Sonner styles and docs#345
Open
hfrancis31 wants to merge 1 commit intomainfrom
Open
feat(apollo-vertex): update Alert and Sonner styles and docs#345hfrancis31 wants to merge 1 commit intomainfrom
hfrancis31 wants to merge 1 commit intomainfrom
Conversation
hfrancis31
requested review from
0xr3ngar,
alincadariu,
angeloaltamiranom,
frankkluijtmans and
ruudandriessen
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency ReviewThe following issues were found:
Vulnerabilitiespnpm-lock.yamlOnly included vulnerabilities with severity high or higher. OpenSSF ScorecardScorecard details
Scanned Files
|
frankkluijtmans
force-pushed
the
Alert-sonner-update
branch
from
e8adf11 to
3ec52e4
Compare
frankkluijtmans
approved these changes
Mar 17, 2026
- Alert: tinted uses opacity modifiers, outline uses bg-card for solid background - Alert: remove info and success statuses; supports default, warning, error only - Sonner: theme-aware color-mix backgrounds (card base light, popover base dark) - Sonner: explicit text/icon/close-button color overrides per status and theme - Docs: two visual styles (tinted, outline), correct status availability per component, Sonner props and API tables added Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
hfrancis31
force-pushed
the
Alert-sonner-update
branch
from
3ec52e4 to
f940d95
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| - name: Setup pnpm | ||
| uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4 | ||
| uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4 |
Check warning
Code scanning / zizmor
detects commit SHAs that don't match their version comment tags Warning
|
|
||
| - name: Setup pnpm | ||
| uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4 | ||
| uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4 |
Check warning
Code scanning / zizmor
detects commit SHAs that don't match their version comment tags Warning
|
|
||
| - name: Setup pnpm | ||
| uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4 | ||
| uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4 |
Check warning
Code scanning / zizmor
detects commit SHAs that don't match their version comment tags Warning
|
|
||
| - name: Setup pnpm | ||
| uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4 | ||
| uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4 |
Check warning
Code scanning / zizmor
detects commit SHAs that don't match their version comment tags Warning
|
|
||
| - name: Setup pnpm | ||
| uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4 | ||
| uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4 |
Check warning
Code scanning / zizmor
detects commit SHAs that don't match their version comment tags Warning
|
|
||
| - name: Setup pnpm | ||
| uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4 | ||
| uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4 |
Check warning
Code scanning / zizmor
detects commit SHAs that don't match their version comment tags Warning
|
|
||
| - name: Setup pnpm | ||
| uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4 | ||
| uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4 |
Check warning
Code scanning / zizmor
detects commit SHAs that don't match their version comment tags Warning
| - name: Setup pnpm | ||
| if: steps.lockfile_check.outputs.changed == 'true' | ||
| uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4 | ||
| uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4 |
Check warning
Code scanning / zizmor
detects commit SHAs that don't match their version comment tags Warning
|
|
||
| - name: Setup pnpm | ||
| uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4 | ||
| uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4 |
Check warning
Code scanning / zizmor
detects commit SHAs that don't match their version comment tags Warning
|
|
||
| - name: Setup pnpm | ||
| uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4 | ||
| uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4 |
Check warning
Code scanning / zizmor
detects commit SHAs that don't match their version comment tags Warning
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| // Shared components | ||
| // ============================================================================ | ||
|
|
||
| function SectionTitle({ children }: { children: React.ReactNode }) { |
| // Shared components | ||
| // ============================================================================ | ||
|
|
||
| function SectionTitle({ children }: { children: React.ReactNode }) { |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 6 days ago
In general, the way to fix an unused function is either to remove it if it is truly unnecessary or to start using it where intended. To avoid changing existing behavior, the safest fix here is to delete the unused SectionTitle component while leaving the rest of the file unchanged.
Concretely, in packages/apollo-wind/src/getting-started/getting-started.stories.tsx, remove the definition of SectionTitle (lines 24–26 in the snippet), which is the function:
function SectionTitle({ children }: { children: React.ReactNode }) {
return <h2 className="mb-2 text-2xl font-bold tracking-tight text-foreground">{children}</h2>;
}No new imports, methods, or variables are needed, and no other parts of the file need to be updated.
Suggested changeset
1
packages/apollo-wind/src/getting-started/getting-started.stories.tsx
| @@ -21,10 +21,6 @@ | ||
| // Shared components | ||
| // ============================================================================ | ||
|
|
||
| function SectionTitle({ children }: { children: React.ReactNode }) { | ||
| return <h2 className="mb-2 text-2xl font-bold tracking-tight text-foreground">{children}</h2>; | ||
| } | ||
|
|
||
| function SectionDescription({ children }: { children: React.ReactNode }) { | ||
| return <p className="mb-6 text-base leading-7 text-muted-foreground">{children}</p>; | ||
| } |
Copilot is powered by AI and may make mistakes. Always verify output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
infoandsuccessstatuses — component now supportsdefault,warning,erroronly. Outline variant usesbg-cardfor a solid opaque background. Tinted variant uses opacity modifiers per status.color-mixbackgrounds (--cardbase in light,--popoverbase in dark). Added explicit text, icon, and close button color overrides per status for both themes. Info toast usescard-foregroundsurface withprimary-foregroundtext for natural inversion across themes.Toasterprops andtoast()API tables.Test plan
/shadcn-components/alert,/shadcn-components/sonner, and/patterns/notifications/in-productdocs pages🤖 Generated with Claude Code