Open
Conversation
maxded
reviewed
Mar 18, 2025
scripts/deep_analysis_example.ipynb
Outdated
Comment on lines
+118
to
+121
| " '../../a_ray_tracing_inline_deep.json',\n", | ||
| " '../../b_ray_tracing_inline_deep.json',\n", | ||
| " '../../a_ray_tracing_pipeline_deep.json',\n", | ||
| " '../../b_ray_tracing_pipeline_deep.json',\n", |
Collaborator
There was a problem hiding this comment.
Don't think we should rely on hardcoded file names/paths
Author
There was a problem hiding this comment.
People will have to enter their own file paths here
maxded
reviewed
Mar 18, 2025
scripts/deep_analysis_example.ipynb
Outdated
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "scores.plot(kind=\"bar\", figsize=(20,5), colormap='Dark2', grid=True, rot=0)" |
Collaborator
There was a problem hiding this comment.
Could we add plotting of all the different score categories. So compare the following:
a_raytracing_inline,a_raytracing_pipelinevsb_raytracing_inlinevsb_raytracing_pipelinea_rasterization_inline,a_rasterization_pipelinevsb_rasterization_inlinevsb_rasterization_pipeline- etc..
Author
There was a problem hiding this comment.
Added it as a separate notebook.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my notebook for generating the following graphs from a comparison between 2 gpu's (a and b as seen in the labels) and between inline and pipeline. There definently is some noise in there, which could be an artefact of certain passes only running once every n frames. Sub millisecond passes also seem to have a bit more noise. Some of the labels are not correct, but I currently do not have a lot of time to flesh out details like this. Hopefully this is a decent starting point for generating some insightful graphs though.
I updated this PR to have a file for every export type. So we get one file for plotting scores, one file for plotting the per frame analysis, and one file for plotting the deep analysis.
Todo:
Below are some of the generated graphs from the different files.
Scores:
Per frame:
Deep analysis: