Mod verification & space colony fixes & destroy defeated factions#8
Open
myszsoda wants to merge 12 commits intoTorannD:mainfrom
Open
Mod verification & space colony fixes & destroy defeated factions#8myszsoda wants to merge 12 commits intoTorannD:mainfrom
myszsoda wants to merge 12 commits intoTorannD:mainfrom
Conversation
In recent fixes we assured that space destination tiles are not scanned when checking for objects in range. But we forgot that player can also be in space and this creates huge log spam since scanning for objects in range for Alert is done all the time. Fix it in two places - in function polling and in Alert call. Signed-off-by: Jakub Raczynski <myszsoda@gmail.com>
This reverts commit ce00543. After considereation and testing, for big ranges and longer saves, having such low limit creates trend towards using caravans mostly, due to amount of friendly settlements in proximity.
Alerts in Rimworld are updated every tick and there are some measures that need to be taken by mods. Generally AlertsReadoutUpdate does update values every 60 ticks, but that is still quite a lot. While solution in this commit is far from optimal, this improves performance a bit and makes notification readable. Signed-off-by: Jakub Raczynski <myszsoda@gmail.com>
In Vanilla faction can be defeated if all its bases are destroyed. This only triggers for player actions so this does not work for RimWar. Defeated factions is highlighted in other way and cannot generate quests, quest raids and raids of course in Vanilla. Add this feature for RimWar, polling if faction has bases once in a while. Signed-off-by: Jakub Raczynski <myszsoda@gmail.com>
Threading still has many problems and we would need to rewrite a lot of logic for proper multithreading. Eg. current codebase does not use mutexes at all and is generally not secured enough to run multithreaded. Also RimWorld itself does change what can be run from main thread and what cannot, so it is better to disable it (by default only). Signed-off-by: Jakub Raczynski <myszsoda@gmail.com>
Recently we added setting of 'defeated' flag for factions without settlements, but we missed option that there might be party on the map that captures settlement. Add check if all parties are dead before defeating faction. Signed-off-by: Jakub Raczynski <myszsoda@gmail.com>
Create separate function that allows passing prefix/sufix function without too much null passing. It makes code more clear and allows to add new patches easier. Also change some function names, there is bit of inconsequential naming of some function (missing prefix/sufix in function name). Signed-off-by: Jakub Raczynski <myszsoda@gmail.com>
People love complaining 'RimWar is broken' while having >800 random mods (true story). We cannot and WILL NOT support some random mods. This commit purpose is to add 'big red warning' that some mods are breaking RimWar. It will work only when RimWar is loaded after them though. One of examples used for testing is VEF (Vanilla Expanded Framework) and VVE (Vanillla Vehicles Expanded). Signed-off-by: Jakub Raczynski <myszsoda@gmail.com>
Remove leftover '$' signs, forgot how strings work in c#. Signed-off-by: Jakub Raczynski <myszsoda@gmail.com>
Original implementation of incompatible mods has not been true in all cases, as we were checking all methods but patching only one usually. This has been fixed by simple check which method is being parsed. Signed-off-by: Jakub Raczynski <myszsoda@gmail.com>
Frankly I would gladly leave it as error to be visible, but change it to warning, as patching will process further, even with incompatible stuff. Signed-off-by: Jakub Raczynski <myszsoda@gmail.com>
Signed-off-by: Jakub Raczynski <myszsoda@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.