Conversation
8480aa7 to
a950774
Compare
jmoggr
left a comment
There was a problem hiding this comment.
Those instructions appear for hash mismatches that are not related to pnpm. pnpm.fetchDeps rolls their own hash checking, so it has a non-standard error message. I'll open a follow up PR with this clarification.
|
Wait, why do we set the |
|
Yeah... we only need to do that for non |
|
I'm working on the fixes, I'll push them here. |
|
I pushed the changes. The |
|
Somehow, later on a different branch, I was not getting the "got" hash when I was doing this again and had to put in empty string. I'm really not sure what I was doing differently. |
|
I vaguely recall seeing something like that at some point, but dismissed it since there were bigger nixy changes. I'll have claude try to grind out a reproduction. |
|
We could just put the advice back to put in the empty string since that always works even if it's a tiny bit more work. |
epatters
left a comment
There was a problem hiding this comment.
Feel free to merge when you're satisfied.
These are a bit too wordy for a situation where we normally "just want to get the check to pass". Also they talk about "instructions given below the error message" which don't seem to exist.