Refactor: simplify validation and improve backtracking cleanup#7258
Merged
DenizAltunkapan merged 2 commits intoTheAlgorithms:masterfrom Feb 5, 2026
Merged
Refactor: simplify validation and improve backtracking cleanup#7258DenizAltunkapan merged 2 commits intoTheAlgorithms:masterfrom
DenizAltunkapan merged 2 commits intoTheAlgorithms:masterfrom
Conversation
This PR makes small readability and maintainability improvements to the algorithm implementation. ### Changes - Removed a redundant `n < 0` validation check since the method contract already ensures valid `n` - Replaced `current.remove(current.size() - 1)` with `current.removeLast()` to better express backtracking intent ### Rationale - Simplifies input validation without changing behavior - Uses the `Deque` API to make the backtracking step clearer and less error-prone ### Impact - No change in algorithm logic or time/space complexity - Output remains identical
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7258 +/- ##
============================================
- Coverage 79.31% 79.31% -0.01%
+ Complexity 6989 6988 -1
============================================
Files 781 781
Lines 22955 22955
Branches 4509 4509
============================================
- Hits 18207 18206 -1
Misses 4020 4020
- Partials 728 729 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DenizAltunkapan
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes small readability and maintainability improvements to the algorithm implementation.
Changes
n < 0validation check since the method contract already ensures validncurrent.remove(current.size() - 1)withcurrent.removeLast()to better express backtracking intentRationale
DequeAPI to make the backtracking step clearer and less error-proneImpact
clang-format -i --style=file path/to/your/file.java