Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds functionality to highlight the status bar button when translation or lookup popovers are displayed, providing visual feedback that matches the existing menu highlight behavior.
Changes:
- Introduced
App+Popover.swiftwith NSPopoverDelegate implementation to intercept popover lifecycle events - Modified
Translator.swiftto set App as delegate for translation popovers - Modified
LookUp.swiftto set App as delegate for lookup popovers
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| TextGrabber2/Sources/App/App+Popover.swift | New file implementing NSPopoverDelegate to highlight/unhighlight status button during popover lifecycle |
| TextGrabber2/Sources/Translator.swift | Added delegate override call before showing translation popover |
| TextGrabber2/Sources/LookUp.swift | Extracted popover reference and added delegate override call before showing lookup popover |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.