refactor: stop logging out after each scraping#27
Draft
Naroh091 wants to merge 12 commits intoTechAndCheck:mainfrom
Draft
refactor: stop logging out after each scraping#27Naroh091 wants to merge 12 commits intoTechAndCheck:mainfrom
Naroh091 wants to merge 12 commits intoTechAndCheck:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current flow opens a browser with a fresh profile, logs in, scrapes, logs out and closes the browser. That's an unnatural behaviour for a real user (who logs in and out continuously?), especially if we got multiple FB jobs in the queue. Also, it takes more time.
This PR removes the logout logic - if it messes up something we can always rollback.