Skip to content

Qual app#9

Merged
marisa07 merged 12 commits intomainfrom
qual-app
Mar 5, 2026
Merged

Qual app#9
marisa07 merged 12 commits intomainfrom
qual-app

Conversation

@marisa07
Copy link
Copy Markdown

@marisa07 marisa07 commented Mar 5, 2026

No description provided.

@marisa07 marisa07 merged commit d2ccbd5 into main Mar 5, 2026
3 of 4 checks passed
@marisa07 marisa07 deleted the qual-app branch March 5, 2026 23:49
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 5, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cc6dd94f-d2d4-4cae-8edc-dd33be57f6ae

📥 Commits

Reviewing files that changed from the base of the PR and between 8d44c90 and 92d6957.

📒 Files selected for processing (5)
  • 2026/qual_config.js
  • pit.html
  • qual.html
  • resources/css/scoutingPASS.css
  • resources/js/googleSheets.js

Summary by CodeRabbit

  • New Features
    • Introduced qualitative scouting interface with multi-page workflow for team evaluation.
    • Added QR code generation for scouting data collection.
    • Tier assignment system with drag-and-drop ranking support.
    • Integrated match data loading from The Blue Alliance API.
    • Enhanced form submission with visual feedback and Google Sheets submission button.
    • Updated header styling and added comprehensive styling for scouting components.

Walkthrough

This pull request introduces a new qualitative scouting feature to ScoutingPass, consisting of a configuration file defining form structure, a multi-page HTML interface for data collection with TBA API integration, updated CSS styling for the new components, and modifications to the Google Sheets data submission handler to support the QUAL data type.

Changes

Cohort / File(s) Summary
Qualitative Scouting Configuration
2026/qual_config.js
New JSON configuration defining qualitative scouting form structure with prematch fields (scouter, event, match, team) and Robot Behavior section containing driving style, defense quality, recovery, alliance play, and fault/tip tracking fields.
Qualitative Scouting Interface
qual.html
New HTML interface implementing multi-page scouting workflow: setup page with form fields and TBA API integration, tier assignment with optional drag-and-drop ranking, and QR code generation encoding match/team/tier data. Includes navigation controls and Google Sheets submission integration.
Styling Updates
resources/css/scoutingPASS.css
New CSS classes for qualitative scouting components (status messages, tier displays, ranking UI, drag elements); color scheme change for h1 header emphasis from cyan/green to red (#C0362C).
Data Submission Handler
resources/js/googleSheets.js
Adds form validation guard, button state management during submission, and conditional data prefixing: "QUAL\t" prefix when qualCollectData function exists. Introduces no-cors fetch mode for Google Sheets requests.
HTML Reformatting
pit.html
Whitespace and formatting adjustments with no functional changes to DOM structure or logic.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Browser as qual.html
    participant TBA as TBA API
    participant QR as QR Generator
    participant Sheets as Google Sheets
    
    User->>Browser: Enter scouter, event, match details
    Browser->>TBA: Fetch match data (if valid event/match)
    TBA-->>Browser: Return alliance & team assignments
    Browser->>Browser: Render teams with alliance colors
    User->>Browser: Assign teams to tiers (drag or manual)
    Browser->>Browser: Collect tier assignments & notes
    User->>Browser: Trigger QR generation
    Browser->>QR: Encode match/team/tier/notes data
    QR-->>Browser: Generate QR code image
    User->>Browser: Submit form
    Browser->>Sheets: POST with QUAL prefix + collected data
    Sheets-->>Browser: Submission confirmed
    Browser->>User: Display success message
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • Pit scouting #8: Modifies googleSheets.js to prepend "PIT\t" prefix to TSV data during submission, mirroring the new QUAL prefix functionality added here.
  • Auto send to google sheets #1: Updates googleSheets.js for data handling and fetch behavior including CORS configuration, directly related to the submission handler modifications in this PR.

Poem

🐰 A new scouting mode hops into view,
With tiers to assign and rankings too,
QR codes dance, TBA data flows,
Qualitative insights—watch scouting grow!

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch qual-app

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant