Adding keepAliveOnHidden option to keep items mounted in case of a tab switch, e.g., in ion-tabs.#1104
Open
j4hangir wants to merge 4 commits intoTanStack:mainfrom
Open
Adding keepAliveOnHidden option to keep items mounted in case of a tab switch, e.g., in ion-tabs.#1104j4hangir wants to merge 4 commits intoTanStack:mainfrom
j4hangir wants to merge 4 commits intoTanStack:mainfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Added keepAliveOnHidden option.
In my app, using ion-tabs, switching between tabs was causing unwanted unmounts/remounts for the items, whereas they're supposed to stay mounted.
The diff is minimal. I haven't tested thoroughly but there can possibly be any side effects, as we have only one extra condition which depends on the given keepAliveOnHidden option.
✅ Checklist
pnpm run test:pr.🚀 Release Impact