fix(react-form): complie error with webpack when react lower than v18#1982
fix(react-form): complie error with webpack when react lower than v18#1982lianghx-319 wants to merge 1 commit intoTanStack:mainfrom
Conversation
Change-Id: Ia4b18c0cf0d6a2c809923588c567f2cabbd08bde
🦋 Changeset detectedLatest commit: 4b819ec The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
It's better to publish a pre-release to ensure it works for webpack project. But I don't know how to trigger the pre-release or test process. |
|
I'll trigger it for you. Let me know the results @lianghx-319 |
|
View your CI Pipeline Execution ↗ for commit 4b819ec
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1982 +/- ##
===========================================
- Coverage 90.35% 54.31% -36.05%
===========================================
Files 38 18 -20
Lines 1752 232 -1520
Branches 444 34 -410
===========================================
- Hits 1583 126 -1457
+ Misses 149 94 -55
+ Partials 20 12 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I will check it this weekend. |
|
Forgot to mention it, but don't worry about the pipeline failing. The line changes are simple enough, especially with the comment explaining its purpose. No need to add unit tests. |
|
I was able to confirm this update works for a webpack project using React 17, #1998 (comment) |
Change-Id: Ia4b18c0cf0d6a2c809923588c567f2cabbd08bde
🎯 Changes
Patch needed to avoid bundlers trying to import non-existing export.
Original PR: iTwin/iTwinUI#1284
Read more: webpack/webpack#14814
✅ Checklist
pnpm test:pr.🚀 Release Impact