fix: react store add-on route path mismatch for code-router#300
Open
StvyaSharma wants to merge 2 commits intoTanStack:mainfrom
Open
fix: react store add-on route path mismatch for code-router#300StvyaSharma wants to merge 2 commits intoTanStack:mainfrom
StvyaSharma wants to merge 2 commits intoTanStack:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the Store add-on with code-router mode in React applications, the build of output template would fail with the following error:
Root Cause
There was a mismatch between theRoute path defined in
info.json:"src/routes/demo.store.tsx"and the actual file location:frameworks/react-cra/add-ons/store/assets/src/routes/demo/store.tsx.ejsThis caused the code-router template to generate an incorrect import path in
main.tsx.ejs:But the actual file was being generated at
./routes/demo/store.tsx(in a subdirectory).The issue only affected code-router mode because:
relativePath(route.path)to generate explicit importsrouteTree.gen, so the path mismatch doesn't matterSolution
Rename the store template file to match the path defined in
info.json: